Fix SSR problems with client only code#602
Open
kiberonlabsdev wants to merge 5 commits intovscode-elements:mainfrom
Open
Fix SSR problems with client only code#602kiberonlabsdev wants to merge 5 commits intovscode-elements:mainfrom
kiberonlabsdev wants to merge 5 commits intovscode-elements:mainfrom
Conversation
Co-authored-by: kiberonlabsdev <210491275+kiberonlabsdev@users.noreply.github.com>
Co-authored-by: kiberonlabsdev <210491275+kiberonlabsdev@users.noreply.github.com>
…support Add SSR guards for CSS stylesheet operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses SSR problems because of client only code. This PR adds guards and delays so that imports to the vscode library don't cause immediate errors even if the actual imported component isn't one of the 2 components included here